Skip to content

Conversation

@r0b1n
Copy link
Collaborator

@r0b1n r0b1n commented Dec 5, 2022

Description

Pull request checklist

  • All new and existing tests passed
  • I run lint command locally and it doesn’t give errors
  • PR title properly formatted [XX-000]: description
  • Added record to packages' CHANGELOG.md
  • Bumped package version in package.json and package.xml
  • Added a link to related project PRs (atlas, pluggable-widgets-tools, testProject, etc.) (optional)
  • Created docs PR to mendix/docs and added a link (optional)

Pull request type

  • No code changes (changes to documentation, CI, metadata, etc)
  • Dependency changes (any modification to dependencies in package.json)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Test related change (New E2E test, test automation, etc.)

What should be covered while testing?

Refresh time works as expected (0 - no refresh) other positive values - time in seconds between refreshes

@r0b1n r0b1n requested a review from a team as a code owner December 5, 2022 16:09
iobuhov
iobuhov previously approved these changes Dec 5, 2022
leonardomendix
leonardomendix previously approved these changes Dec 9, 2022
@r0b1n r0b1n dismissed stale reviews from leonardomendix and iobuhov via 5efc470 December 9, 2022 10:44
@r0b1n r0b1n force-pushed the feat/dg2-refresh-on-interval branch from 35dbc80 to 5efc470 Compare December 9, 2022 10:44
@r0b1n r0b1n merged commit b6a3b8b into main Dec 9, 2022
@r0b1n r0b1n deleted the feat/dg2-refresh-on-interval branch December 9, 2022 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants