Skip to content

Conversation

@iobuhov
Copy link
Collaborator

@iobuhov iobuhov commented Dec 8, 2022

Description

This PR introduces new build step, to handle pnpm install step failure on dependabot PRs
This step is meant to update pnpm-lock.yaml file on Dependabot
pull requests. Right now dependabot not work fine with monorepos
so we have to do extra work to automatically update lock file.
This step is part of "check" job, but could be part of any other job.
We put it here just because previous Install dependencies step is just
first "install" in this workflow.
The idea of this step - if install fails, try to fix lock file, commit and
push changes.
NOTE: we use magic string ([dependabot skip]) to allow branch rebase, read more at link below.
https://docs.github.com/en/code-security/dependabot/working-with-dependabot/managing-pull-requests-for-dependency-updates#allowing-dependabot-to-rebase-and-force-push-over-extra-commits

Pull request type

  • No code changes (changes to documentation, CI, metadata, etc)
  • Dependency changes (any modification to dependencies in package.json)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Test related change (New E2E test, test automation, etc.)

What should be covered while testing?

  • After merging this PR we need to instruct dependabot to rebase one or two PRs and see if failure handling executes correctly.

@iobuhov iobuhov marked this pull request as ready for review December 8, 2022 17:01
@iobuhov iobuhov requested a review from a team as a code owner December 8, 2022 17:01
@iobuhov iobuhov changed the title ci: handle pnpm install failure in dependabot prs [WC-1550]: Handle pnpm install failure in dependabot PRs Dec 8, 2022
@iobuhov
Copy link
Collaborator Author

iobuhov commented Dec 12, 2022

cc: @leonardomendix

@iobuhov iobuhov merged commit c4b32ec into main Dec 12, 2022
@iobuhov iobuhov deleted the WC-1550/fix-pnpm-lock-on-dependabot-pr branch December 12, 2022 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants