Skip to content

[WC-3295] Fix dg2 'clickable' class issue#2134

Merged
gjulivan merged 2 commits intomainfrom
3295/dg2-cursor-change-clickable-class
Apr 21, 2026
Merged

[WC-3295] Fix dg2 'clickable' class issue#2134
gjulivan merged 2 commits intomainfrom
3295/dg2-cursor-change-clickable-class

Conversation

@iobuhov
Copy link
Copy Markdown
Collaborator

@iobuhov iobuhov commented Mar 11, 2026

Pull request type

Bug fix (non-breaking change which fixes an issue)


Description

Fixed isInteractive flag to return true only for rowClick selection or onClick action.
Previously returned true for any selection including checkbox, causing incorrect pointer cursor.
Added comprehensive test coverage (33 tests, 100% coverage).

What should be covered while testing?

  1. Checkbox selection: rows should NOT show pointer cursor
  2. Row click selection: rows SHOULD show pointer cursor
  3. onClick action: rows SHOULD show pointer cursor

… or onClick action

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@iobuhov iobuhov requested a review from a team as a code owner March 11, 2026 14:09
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@gjulivan gjulivan merged commit 5a174ba into main Apr 21, 2026
14 checks passed
@gjulivan gjulivan deleted the 3295/dg2-cursor-change-clickable-class branch April 21, 2026 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants