[WC-1312]: previews for HTML element widget #30
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iobuhov
previously approved these changes
Oct 24, 2022
r0b1n
force-pushed
the
feat/html-element-previews
branch
from
75ed0db to
851a200
Compare
iobuhov
reviewed
Oct 27, 2022
packages/pluggableWidgets/html-element-web/src/HTMLElement.editorConfig.ts
Show resolved
Hide resolved
r0b1n
force-pushed
the
feat/html-element-previews
branch
from
cc6ec11 to
9eedb5c
Compare
iobuhov
reviewed
Oct 27, 2022
packages/pluggableWidgets/html-element-web/src/HTMLElement.editorPreview.tsx
Outdated
Show resolved
Hide resolved
iobuhov
previously approved these changes
Oct 28, 2022
As suggested by PAG team, instead of using custom require-ness check on data source, make data source required, when data source is hidden in props, this effectively works as it is not required, no checks run on it.
This adds design preview, the iteration over items is needed to represent repeating nodes of the widget, though in case of HTML content the items are not greyed out
uicontent
force-pushed
the
feat/html-element-previews
branch
from
f8a16c5 to
09ded62
Compare
leonardomendix
approved these changes
Nov 14, 2022
rahmanunver
approved these changes
Nov 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
[XX-000]: description)? ✅Web specific
Feature specific
This PR contains
What is the purpose of this PR?
Introduce structure and design previews for HTML Element 🎉