Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
89 changes: 67 additions & 22 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
@@ -1,31 +1,76 @@
### Description
<!--
IMPORTANT: Please read and follow instructions below on how to
open and submit your pull request.

<!--- Describe your changes in detail -->
REQUIRED STEPS:
1. Specify correct pull request type.
2. Write meaningful description.
3. Run `pnpm lint` and `pnpm test` in packages you changed and make sure they have no errors.
4. Add new tests (if needed) to cover new functionality.
5. Read checklist below.

### Pull request checklist
CHECKLIST:
- Do you have a JIRA story for your pull request?
- If yes, please format the PR title to match the `[XX-000]: description` pattern.
- If no, please write your PR title using conventional commit rules.
- Does your change require a new version of the widget/module?
- If yes, run `pnpm -w changelog` or update the `CHANGELOG.md` and bump the version manually.
- If no, ignore.
- Do you have related PRs in other Mendix repositories?
- If yes, please link all related pull requests in the description.
- If no, ignore.
- Does your change touch XML, or is it a new feature or behavior?
- If yes, if necessary, please create a PR with updates in the documentation (https://github.com/mendix/docs).
- If no, ignore.
- Is your change a bug fix or a new feature?
- If yes, please add a description (last section in the template) of what should be tested and what steps are needed to test it.
- If no, ignore.
-->

<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->
<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->
<!--
What type of changes does your PR introduce?
Uncomment relevant sections below by removing `<!--` at the beginning of the line.
-->

- [ ] All new and existing tests passed
- [ ] I run `lint` command locally and it doesn’t give errors
- [ ] PR title properly formatted `[XX-000]: description`
- [ ] Added record to packages' CHANGELOG.md
- [ ] Bumped package version in `package.json` and `package.xml`
- [ ] Added a link to related project PRs (atlas, pluggable-widgets-tools, testProject, etc.) (optional)
- [ ] Created docs PR to [mendix/docs](https://github.com/mendix/docs.git) and added a link (optional)
### **Pull request type**

### Pull request type
<!-- No code changes (changes to documentation, CI, metadata, etc.)
<!---->

<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
<!-- Dependency changes (any modification to dependencies in `package.json`)
<!---->

- [ ] No code changes (changes to documentation, CI, metadata, etc)
- [ ] Dependency changes (any modification to dependencies in `package.json`)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] Test related change (New E2E test, test automation, etc.)
<!-- Refactoring (e.g. file rename, variable rename, etc.)
<!---->

### What should be covered while testing?
<!-- Bug fix (non-breaking change which fixes an issue)
<!---->

<!-- New feature (non-breaking change which adds functionality)
<!---->

<!-- Breaking change (fix or feature that would cause existing functionality to change)
<!---->

<!-- Test related change (New E2E test, test automation, etc.)
<!---->

---

<!--- Describe what part of pacakge need to be tested and more important - how -->
<!---
Describe your changes in detail.
Try to explain WHAT and WHY you change, fix or refactor.
-->

### **Description**

---

<!--
Please uncomment and fill in the following section
to describe which part of the package needs to be tested
and how it can be tested.
-->
<!--
### What should be covered while testing?
-->