feat(image-web): support icon collections #441
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iobuhov
reviewed
Mar 16, 2023
packages/pluggableWidgets/image-web/src/components/Image/ui.tsx
Outdated
Show resolved
Hide resolved
iobuhov
previously approved these changes
Mar 16, 2023
Co-authored-by: Illia Obukhau <vyusfire@gmail.com>
takumagott
force-pushed
the
feat/support-custom-icon-collections
branch
from
3845536 to
deb805f
Compare
leonardomendix
approved these changes
Mar 17, 2023
r0b1n
approved these changes
Mar 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
New feature (non-breaking change which adds functionality)
This PR adds support for icon collections (release as part of 9.24)
Page editor epic: https://mendix.atlassian.net/browse/PAG-2025
Description
This particularly affects the usage of icons, but everything (image, image icon, custom icon, glyph icon) should be tested. Requires using Studio Pro with the feature flag
--enable-custom-icon-collections. When it comes to testing, hit me up so I can provide you with a module with custom icons that you can simply import.What should be covered while testing?
see description