Skip to content

fix(selection-helper-web): fix missing class and style props #460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
r0b1n merged 2 commits into from
Mar 20, 2023
Merged

fix(selection-helper-web): fix missing class and style props #460

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9e9524a
fix(selection-helper-web): fix missing class and style props
r0b1n Mar 20, 2023
7912ae8
fix(selection-helper-web): add missing release script
r0b1n Mar 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/pluggableWidgets/selection-helper-web/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@
"build": "pluggable-widgets-tools build:web",
"format": "prettier --write .",
"lint": "eslint --ext .jsx,.js,.ts,.tsx src/",
"release": "pluggable-widgets-tools release:ts",
"verify": "rui-verify-package-format",
"update-changelog": "rui-update-changelog-widget"
},
Expand Down
7 changes: 6 additions & 1 deletion packages/pluggableWidgets/selection-helper-web/src/SelectionHelper.editorPreview.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,12 @@ import { SelectionHelperComponent } from "./components/SelectionHelperComponent"

export function preview(props: SelectionHelperPreviewProps): ReactElement {
return (
<SelectionHelperComponent type={props.renderStyle} status="some">
<SelectionHelperComponent
type={props.renderStyle}
status="some"
className={props.class}
cssStyles={props.styleObject}
>
{props.renderStyle === "custom"
? [
<props.customNoneSelected.renderer key={"none"} caption={"No items selected: Place widgets here"}>
Expand Down
8 changes: 7 additions & 1 deletion packages/pluggableWidgets/selection-helper-web/src/SelectionHelper.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,13 @@ export function SelectionHelper(props: SelectionHelperContainerProps): ReactElem
const selection = contextValue.value;

return (
<SelectionHelperComponent type={props.renderStyle} status={selection.status} onClick={selection.toggle}>
<SelectionHelperComponent
type={props.renderStyle}
status={selection.status}
onClick={selection.toggle}
className={props.class}
cssStyles={props.style}
>
{selection.status === "all" && props.customAllSelected}
{selection.status === "some" && props.customSomeSelected}
{selection.status === "none" && props.customNoneSelected}
Expand Down
6 changes: 4 additions & 2 deletions packages/pluggableWidgets/selection-helper-web/src/components/SelectionHelperComponent.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,13 @@
import { createElement, ReactElement, ReactNode, useMemo } from "react";
import { createElement, CSSProperties, ReactElement, ReactNode, useMemo } from "react";
import { ThreeStateCheckBox } from "@mendix/pluggable-widgets-commons/components/web";

interface Props {
type: "checkbox" | "custom";
status: "all" | "some" | "none";
onClick?: () => void;
children: ReactNode;
className: string;
cssStyles?: CSSProperties;
}

export function SelectionHelperComponent(props: Props): ReactElement {
Expand All @@ -14,7 +16,7 @@ export function SelectionHelperComponent(props: Props): ReactElement {
}, []);

return (
<div className="widget-selection-helper">
<div className={`widget-selection-helper ${props.className}`} style={props.cssStyles}>
{props.type === "custom" ? (
<div
className="selection-helper-custom"
Expand Down