Skip to content

[WC-1759]: fix id clash for widgets with the same name #462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
r0b1n merged 1 commit into from
Mar 22, 2023
Merged

[WC-1759]: fix id clash for widgets with the same name #462

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/pluggableWidgets/rich-text-web/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,10 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),

## [Unreleased]

### Fixed

- We fixed an issue with Rich Text widget not working correctly when another Rich Text widget is opened in a popup.

## [2.1.3] - 2023-01-31

### Fixed
Expand Down
2 changes: 1 addition & 1 deletion packages/pluggableWidgets/rich-text-web/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "rich-text-web",
"widgetName": "RichText",
"version": "2.1.3",
"version": "2.1.4",
"description": "Rich inline or toolbar text editing",
"copyright": "© Mendix Technology BV 2023. All rights reserved.",
"repository": {
Expand Down
4 changes: 2 additions & 2 deletions packages/pluggableWidgets/rich-text-web/src/components/RichText.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import classNames from "classnames";
import { Editor } from "./Editor";

export function RichText(props: RichTextContainerProps): JSX.Element | null {
const { width: w, height: h, widthUnit, heightUnit, readOnlyStyle, name, id } = props;
const { width: w, height: h, widthUnit, heightUnit, readOnlyStyle, id } = props;
const [element, setElement] = useState<HTMLElement | null>(null);

if (props.stringAttribute.status !== "available") {
Expand All @@ -28,7 +28,7 @@ export function RichText(props: RichTextContainerProps): JSX.Element | null {
className={classNames("widget-rich-text", `${readOnly ? `editor-${readOnlyStyle}` : ""}`)}
style={{ width, height }}
>
<div ref={setElement} id={name} />
<div ref={setElement} />
{element ? <Editor element={element} widgetProps={props} /> : null}
</div>
);
Expand Down
4 changes: 1 addition & 3 deletions ...ggableWidgets/rich-text-web/src/components/__tests__/__snapshots__/RichText.spec.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,6 @@ exports[`RichText render DOM structure 1`] = `
}
}
>
<div
id="RichText_Div"
/>
<div />
</div>
`;
2 changes: 1 addition & 1 deletion packages/pluggableWidgets/rich-text-web/src/package.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="utf-8" ?>
<package xmlns="http://www.mendix.com/package/1.0/">
<clientModule name="RichText" version="2.1.3" xmlns="http://www.mendix.com/clientModule/1.0/">
<clientModule name="RichText" version="2.1.4" xmlns="http://www.mendix.com/clientModule/1.0/">
<widgetFiles>
<widgetFile path="RichText.xml" />
</widgetFiles>
Expand Down