[WC-1698]: Replace glyphicons in pluggableWidgets #504
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rahmanunver
force-pushed
the
WC-1698_remove_glypicons
branch
from
ef0c017 to
46f977a
Compare
iobuhov
reviewed
May 5, 2023
packages/modules/data-widgets/src/themesource/datawidgets/web/_datagrid.scss
Outdated
Show resolved
Hide resolved
packages/modules/data-widgets/src/themesource/datawidgets/web/_datagrid.scss
Outdated
Show resolved
Hide resolved
rahmanunver
force-pushed
the
WC-1698_remove_glypicons
branch
from
a595119 to
f3a9214
Compare
iobuhov
approved these changes
May 23, 2023
leonardomendix
approved these changes
May 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
Refactoring (e.g. file rename, variable rename, etc.)
Description
Changed icons for data-widgets(
datagrid-date-filter-web),rating-web, and Pagination(pluggable-widgets-commons)What should be covered while testing?
If icons were replaced fine and their styles are ok, no behavioural or event changes made.