Skip to content

Conversation

@iobuhov
Copy link
Collaborator

@iobuhov iobuhov commented Nov 14, 2022

Description

This PR does two things:

  • Fix build and release scripts for calendar-web
  • Prepare calendar-web v1.0.14 release

Pull request type

  • No code changes (changes to documentation, CI, metadata, etc)
  • Dependency changes (any modification to dependencies in package.json)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Test related change (New E2E test, test automation, etc.)

What should be covered while testing?

  • Probably build and release commands

@iobuhov iobuhov requested a review from a team as a code owner November 14, 2022 17:06
Copy link
Contributor

@HedwigAR HedwigAR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, looks like there was a bit more changed than a library update. I see the package json was changed due to a pluggable widget tools update so I get that. Why was the build.ts added?

@iobuhov
Copy link
Collaborator Author

iobuhov commented Nov 17, 2022

Why was the build.ts added?

As you may noticed, calendar-web is located in packages/customWidgets and this package is still use webpack under the hood. build.ts was added because I simplified widget build and removed dependency on gulp.
P.S. TLDR; We need build.ts because this widget is not uses pluggable-widgets-tools yet. Once this widget will be migrated to "pluggable" we will remove this script.

HedwigAR
HedwigAR previously approved these changes Nov 17, 2022
Copy link
Contributor

@HedwigAR HedwigAR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright! I didn't actually notice it was in customWidgets, thanks for the explanation!

@iobuhov iobuhov force-pushed the WC-1415/update-momentjs-in-calendar-web branch from 181756b to 2f0f5fc Compare November 17, 2022 13:46
@iobuhov iobuhov force-pushed the WC-1415/update-momentjs-in-calendar-web branch from 2f0f5fc to 7bc38b2 Compare November 22, 2022 16:10
@iobuhov iobuhov merged commit 3f955c6 into main Nov 23, 2022
@iobuhov iobuhov deleted the WC-1415/update-momentjs-in-calendar-web branch November 23, 2022 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants