Skip to content

[WC-1416]: Update vulnerable dependencies #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
iobuhov merged 3 commits into from
Nov 21, 2022
Merged

[WC-1416]: Update vulnerable dependencies #61

iobuhov merged 3 commits into from
Nov 21, 2022

Conversation

@iobuhov
Copy link
Collaborator

@iobuhov iobuhov commented Nov 15, 2022

Description

Updated libraries:

  • d3-color to v3.1.0
  • ckeditor4 to v4.20.0

Pull request type

  • No code changes (changes to documentation, CI, metadata, etc)
  • Dependency changes (any modification to dependencies in package.json)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Test related change (New E2E test, test automation, etc.)

What should be covered while testing?

  • RichText - need health check, just to make sure it loads and renders correctly
  • Charts - health check, probably just run Atlas Design System app with updated widget

@iobuhov iobuhov requested a review from a team as a code owner November 15, 2022 13:36
rahmanunver
rahmanunver previously approved these changes Nov 16, 2022
View reviewed changes
@iobuhov iobuhov changed the title [WC-1416] Update vulnerable dependencies [WC-1416]: Update vulnerable dependencies Nov 17, 2022
@iobuhov iobuhov force-pushed the WC-1416/security-fixes branch from b68717f to eecb190 Compare November 17, 2022 13:48
@iobuhov iobuhov merged commit df22309 into main Nov 21, 2022
@iobuhov iobuhov deleted the WC-1416/security-fixes branch November 21, 2022 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rahmanunver rahmanunver rahmanunver approved these changes

@leonardomendix leonardomendix leonardomendix approved these changes

Assignees

No one assigned

Labels

charts-web rich-text-web

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@iobuhov @rahmanunver @leonardomendix