Crafting: Programmatically run generator from bin script#125
Merged
LEGIO-SEXTA-FERRATA merged 3 commits intomasterfrom May 19, 2025
Merged
Crafting: Programmatically run generator from bin script#125LEGIO-SEXTA-FERRATA merged 3 commits intomasterfrom
LEGIO-SEXTA-FERRATA merged 3 commits intomasterfrom
Conversation
Contributor
LEGIO-SEXTA-FERRATA
left a comment
LEGIO-SEXTA-FERRATA
left a comment
There was a problem hiding this comment.
Finished a review pass, added a single comment.
A question, though: I assume you didn't bump the version because your previous PR did?
LEGIO-SEXTA-FERRATA
approved these changes
May 19, 2025
Contributor
LEGIO-SEXTA-FERRATA
left a comment
LEGIO-SEXTA-FERRATA
left a comment
There was a problem hiding this comment.
Tested: A few different combinations of generation configurations. ✅
Unintentionally tested 😄: When the directory is not empty. ✅
Approved. ☝🏻
Well done @weirdwater. 👏🏻
alihcsumer
approved these changes
May 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
[XX-000]: description)? ✅This PR contains
What is the purpose of this PR?
There was a noticeable startup time when generating a widget using
npx @mendix/generator-widget. This was due to the bin script installing yeoman and the generator globally each time.Relevant changes
yeoman-environment(which theyocli tool is a wrapper for).npm auditWhat should be covered while testing?
Generating a widget using the
bin.jsscript.