Skip to content

Add missing dependencies for release tooling#134

Merged
weirdwater merged 5 commits intomasterfrom
pnpm-workspaces-releases
Aug 22, 2025
Merged

Add missing dependencies for release tooling#134
weirdwater merged 5 commits intomasterfrom
pnpm-workspaces-releases

Conversation

@weirdwater
Copy link
Collaborator

A few dependencies slipped through the cracks when migrating to pnpm: #132

@weirdwater weirdwater requested a review from a team as a code owner August 20, 2025 15:13
@weirdwater weirdwater force-pushed the pnpm-workspaces-releases branch from d9e0b9f to ce0d6d8 Compare August 21, 2025 10:15
@weirdwater
Copy link
Collaborator Author

The issue with the PWT command tests turned out to be that the node setup action would attempt to cache the pnpm-store. But since the pnpm install command was behind an if-condition the store would not fill up. Reviewing the conditional steps it became clear that the workflow did not do anything if the path filters were not met.

Since there was also no difference in behavior based on the "packages" and "tests" filters I decided to move these conditions to the workflow level, simplifying the script.

Armed with the knowledge that with pnpm there really is no point in caching the node_modules directory and that the node-setup action already caches the pnpm store I removed the existing caching strategy.

I have also applied these lessons to the unit test workflow.

@weirdwater weirdwater merged commit c38f0bb into master Aug 22, 2025
7 checks passed
@weirdwater weirdwater deleted the pnpm-workspaces-releases branch August 22, 2025 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants