[MOO-1847]: Include @d11/react-native-fast-image as an external native dependancy in rollup config#140
Conversation
|
Does this change rely on a specific version of Studio Pro? |
|
I think it should not matter as long as we make this config available for SP11. For earlier versions we are not going to introduce @d11/react-native-fast-image so having or not having this config there does not matter. |
|
But if the widget is used in a version of mendix that does not have that dependency available at runtime the widget will fail, right? |
|
Right, for that minimum SP version(11.3) check will be added in widget itself before releasing new version with this dependancy. So we just have to make sure this config should be present in widget tools where widgets are targeted for SP11.3 and above. Even if we expose this config to SP11.2 this wont hurt existing widget since existing widget does not use this dependancy. |
|
Widget will fail if run in Mendix version which does not include this dependency. |
|
In that case I would advise against this approach, since we cannot expect customers to always use the latest version, especially version 11 while it is beta. I would propose providing an example custom |
|
This PR has been discussed with the team. We can proceed with adding the dependency to the list of externals. We just need to update the version of the pluggable-widgets-tools package to 11.3.0 to indicate the minimum version of Mendix that is compatible with the tools. |
|
@weirdwater thanks for the update. I have bumped pluggable-widgets-tools version to 11.3.0, please review. |
|
@mendix-widgets-framework can i get one more approval on this? |
5 participants
Checklist
[XX-000]: description)? ✅This PR contains
What is the purpose of this PR?
Update rollup native config to include @d11/react-native-fast-image dependancy to avoid duplicate symbols error