[WTF-2697]: Widget Bundler 11.11.0 does not copy (all) files on windows#185
Merged
Conversation
alihcsumer
changed the title
Contributor
Author
|
The assertion for the mpk is used twice but it is now unified with the file assertion. Removed the misleading comment. |
alihcsumer
force-pushed
the
fix/windows-mpk-xml
branch
from
6a5ee76 to
f651e90
Compare
weirdwater
approved these changes
Jun 23, 2026
stdagkalakis
approved these changes
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Contains unit tests ✅
Contains breaking changes ❌
Compatible with: MX 9️⃣ (11.x)
Did you update version and changelog? ✅ changelog / ❌ version
PR title properly formatted? ✅
This PR contains
Bug fix
What is the purpose of this PR?
Fix Windows builds producing an .mpk missing the widget's .xml files and icon/tile PNGs.
Relevant changes
The copy step used absolute drive-letter globs that fast-glob returns empty for on Windows, so the widget files were silently skipped; switched both rollup configs to relative globs and added an assertion in command-tests so an incomplete .mpk
What should be covered while testing?
Build on Windows and Linux; confirm the .mpk contains package.xml and .xml (and PNGs when present in src).