Skip to content

Handle merged microflow review follow-ups #459

@hjotha

Description

@hjotha

Summary

A few review follow-ups from recently merged microflow PRs were still open after the original fixes landed:

  • enum split branches beyond the supported anchor table were silently emitted without stable branch anchors;
  • loop @caption metadata was covered by unit/bug tests but not by a doctype-level example;
  • the SOAP call web service grammar comment still described string literals as the preferred structured form, even though qualified names are now preferred.

Expected behavior

  • MDL validation should reject enum splits that exceed the currently supported branch layout instead of producing partially anchored flows.
  • The doctype examples should include loop activity metadata.
  • Grammar comments should describe the current syntax accurately.

Proposed fix

  • Add validation and builder errors for enum splits with more branches than the supported anchor table.
  • Add a doctype microflow example using @caption on a loop.
  • Update the SOAP call web service grammar comment to document qualified names as the preferred structured reference form and string literals as fallback for dangling raw IDs.

Validation

  • make build
  • ./bin/mxcli check mdl-examples/doctype-tests/02-microflow-examples.mdl
  • go test ./mdl/executor -run 'EnumSplit|ValidateMicroflow.*EnumSplit' -count=1
  • make test
  • make lint-go

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions