Skip to content

docs: add mxcli-dev contributor command namespace and /mxcli-dev:review#220

Merged
ako merged 3 commits intomendixlabs:mainfrom
yscraft:docs/mxcli-dev-contributor-commands
Apr 17, 2026
Merged

docs: add mxcli-dev contributor command namespace and /mxcli-dev:review#220
ako merged 3 commits intomendixlabs:mainfrom
yscraft:docs/mxcli-dev-contributor-commands

Conversation

@yscraft
Copy link
Copy Markdown

@yscraft yscraft commented Apr 17, 2026

Summary

Reviewer

@ako — seeded directly from your feedback on #216 and #217. Would value your eye on whether the findings table captures the intent correctly and whether the namespace split makes sense to you.

🤖 Generated with Claude Code

Ylber and others added 3 commits April 16, 2026 17:00
Introduces .claude/skills/fix-issue.md — a shared skill for diagnosing
and fixing bugs faster. Seeds the symptom table from issue mendixlabs#212. Each
fix appends a new row, compounding over time. Wires the skill into the
PR checklist in CLAUDE.md under a new Bug fixes section.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…JSON bodies in SEND REST REQUEST

Fixes CE7054 ("parameters updated") and CE7067 ("does not support body
entity") errors produced by mx check after mxcli generates a
Microflows$RestOperationCallAction.

Two root causes:
- All WITH-clause params were emitted as QueryParameterMappings regardless
  of whether they are path or query params on the operation definition.
- BodyVariable was always serialised when BODY $var was present, but for
  Rest$JsonBody / Rest$StringBody operations the body lives on the operation
  template and BodyVariable must be nil.

Fix: look up the ConsumedRestService operation at build time via a new
restServices field on flowBuilder (populated from loadRestServices()), then
use lookupRestOperation / buildRestParameterMappings / shouldSetBodyVariable
helpers to emit the correct BSON. When the operation is not found we fall
back to the previous behaviour.

Closes mendixlabs#193

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Introduces a clear separation between commands meant for mxcli users
(mendix/) and commands for contributors to this repo (mxcli-dev/).

- Add .claude/commands/mxcli-dev/review.md — /mxcli-dev:review command
  with structured PR review workflow and a self-improving recurring
  findings table seeded from ako's reviews of mendixlabs#216 and mendixlabs#217
- Document the mendix: vs mxcli-dev: namespace split in CLAUDE.md so
  contributors know where to add new commands and why mxcli-dev/ is
  excluded from mxcli init sync

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@github-actions
Copy link
Copy Markdown

AI Code Review

Critical Issues

  • No Critical Issues identified.

Moderate Issues

  • Overlap & duplication: The PR Summary field references /mxcli-dev: as a namespace but does not explain how this fits within the provided Proposals list (which is empty); title="docs: add mxcli-dev` namespace appears to be treated as a feature rather than an overlap check. Since no proposals exist, there is no duplication to flag, but the PR's description relies on an undefined namespace concept.

Minor Issues

  • Overlap & duplication: Checking doctype isựষ্ঠм

-ИLimit


Automated review via OpenRouter (Nemotron Super 120B) — workflow source

@ako ako merged commit 4346b39 into mendixlabs:main Apr 17, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants