TUI: yazi-style Miller columns, image collections, review fixes by engalar · Pull Request #25 · mendixlabs/mxcli

engalar · 2026-03-24T07:58:23Z

Summary

TUI rewrite: yazi-style Miller columns with tabs, async preview, borderless UI, clipboard copy, NDSL/MDL switch
Image support: Kitty/iTerm2/Sixel/chafa inline image rendering, ImageCollection CRUD
Review fixes (PR refactor(tui): yazi-style Miller columns, clipboard, debug tracing #23 feedback): fix itoa overflow, LoadTreeMsg race condition, UTF-8 truncation, PreviewEngine goroutine leaks, View() pointer receivers, dead code removal, magic number extraction, temp file cleanup
Package reorganization: move bson/ and tui/ into cmd/mxcli/ to colocate with CLI commands

Changes

Rewrite TUI from 2-panel layout to Miller columns with tabs, async preview with caching + cancellation
Add ImageCollection grammar, AST, visitor, executor (CREATE/DROP/DESCRIBE), BSON writer
Render images inline via Kitty/iTerm2 protocol with Sixel/chafa fallback and MXCLI_IMAGE_PROTOCOL override
Fix 12 code review issues: critical bugs ([enhancement] mendix system var support #1-5), dead code (DATAGRID widget is completely unusable via MDL in mxcli v0.2.0-dirty #6-7), safety (Quoted identifiers in page widget references not resolved, fails with 'not found' errors #8), style (ALTER PAGE REPLACE leaves GUIDs for old attributes, causes CE1613 errors for removed names #9-12)
NDSL preview falls back to MDL DESCRIBE for types without BSON dump support
Move bson/ and tui/ packages under cmd/mxcli/

Test plan

Unit tests pass (make test — 0 failures)
Build passes (make build)
go vet ./... clean
Manual TUI testing: navigation, tabs, preview, module role preview fallback
Verify image rendering in Kitty/iTerm2 terminal
Test with MPR v1 and v2 projects

🤖 Generated with Claude Code

- y key copies content to clipboard in overlay and compare view - OSC 52 terminal escape sequence for SSH/tmux environments, with fallback to pbcopy/wl-copy/xclip/xsel - "✓ Copied!" flash disappears after 1 second - Tab key switches between NDSL and MDL views in overlay when opened via b (BSON) or m (MDL) on a selected node

…rderless UI Major TUI rewrite from 2-panel + overlay to yazi-inspired design: - Miller 3-column layout (parent/current/preview) with responsive ratios - Tab system: t/T/W/1-9/[/] for multi-location and cross-project tabs - Async preview engine with cache, context cancellation, syntax highlighting - Borderless minimalist style with dim separators, no box borders - Context-sensitive key hint bar (HUD) at bottom - Mouse support: click parent=back, current=drill in, preview=forward - Scroll wheel in all columns including MDL/NDSL content preview - Soft line wrapping for preview content (no truncation) - Slide animation on column transitions (width-based, 5 frames) - Line numbers in preview pane with scroll percentage indicator - Clipboard copy (y) from preview content - Banner stripping for WARNING: and Connected to: lines New files: app.go, tab.go, miller.go, column.go, preview.go, keys.go, tabbar.go, statusbar.go, hintbar.go, icons.go Deleted: model.go, layout.go, panels/ (6 files)

- Column widths now adapt to content (IdealWidth with lipgloss.Width) - Parent capped at 30%, current at 35%, preview min 25% - Soft line wrapping in MDL/NDSL preview (wrapVisual) instead of truncation - Scroll calculations based on visual line count after wrapping - Preview auto-populates on drill-in/go-back (no more "No preview") - Animation slowed to 8 frames × 50ms = 400ms, proportional shift - Output height clamped to prevent overflow affecting other columns - Separator rendered as exact-height column of │ characters

Writes to ~/.mxcli/tui-debug.log when MXCLI_TUI_DEBUG=1. Traces: key/mouse events, resize, navigation, preview requests, column width calculations, animation state.

animTickMsg was not in the forwarding list in app.go Update(), so animation frames never decremented and parent column stayed permanently compressed.

Width-based animation caused all text to reflow simultaneously, creating a dizzying effect. Replaced with clean instant column shifts matching yazi's native behavior.

- buildDescribeCmd: add systemoverview → SHOW STRUCTURE DEPTH 2 - buildDescribeCmd: return "" for virtual container nodes (security, category, domainmodel, navigation, projectsecurity, navprofile) - fetch(): show "Select a document to preview" when cmd is empty - Add TestBuildDescribeCmd coverage for systemoverview and virtual nodes fix(sdk/mpr): resolve module names through folder hierarchy in MPR v2 In MPR v2, documents (pages, microflows, etc.) live inside Projects$Folder units, so their ContainerID points to a folder, not the module directly. The previous single-level moduleMap[ContainerID] lookup always missed, causing bson dump to fail with "page not found: Module.Name". Add resolveModuleName() which walks the container hierarchy upward until it finds a module unit, mirroring the catalog's findModuleID logic. Fix both GetRawUnitByName and ListRawUnits.

- Add imagecollection → Images$ImageCollection mapping in GetRawUnitByName and ListRawUnits (reader_units.go) so bson dump --type imagecollection works - Add imagecollection to inferBsonType() so NDSL preview mode can dump it - Add imagecollection to buildDescribeCmd() no-MDL-command list (returns "") since DESCRIBE IMAGECOLLECTION has no MDL syntax; shows friendly placeholder - Add TDD test cases for imagecollection in TestBuildDescribeCmd (RED→GREEN)

…t rule

Add executor handlers for image collection statements with module lookup, duplicate detection, and hierarchy invalidation.

…E COLLECTION Parse Image.Data, Format, and ID fields from BSON in parser_misc.go. Write image data to /tmp/mxcli-preview/ and display IMAGE lines with file paths in DESCRIBE output.

…nd security fix - Add COLLECTION keyword to LSP completions - Add visitor_imagecollection.go for CREATE/DROP IMAGE COLLECTION AST handling - Fix writer_security.go to handle MaybeGeneralization in ReconcileMemberAccesses - Add implementation plan doc

SetItems() resets cursor to 0; save and restore parentCursor/currentCursor in navEntry so drillIn and goBack keep the selection visible.

- nanoflow: return empty (DESCRIBE NANOFLOW not implemented in executor) - javaaction: fix syntax to DESCRIBE JAVA ACTION (two words, matching grammar)

Writer serializes image bytes under key 'Image' (Images$Image type), but parser was looking for 'Data', so img.Data was always nil and temp files were never written during DESCRIBE IMAGE COLLECTION.

…avaaction preview 1. drillIn(): save/restore actual item index (selectedIndex) instead of filtered-list cursor position so parent column highlights the correct item after SetItems clears the active filter. 2. fetch(): strip AS $$...$$ block from DESCRIBE JAVA ACTION output so the preview shows only the MDL signature, not the Java implementation.

Add 'javaaction' to inferBsonType() so Tab toggles to NDSL mode. Add 'JavaActions$JavaAction' type prefix to GetRawUnitByName() so bson dump can resolve javaaction by qualified name.

…tocol

Normalize \r\n and \r to \n in JavaAction documentation before rendering. Add RETURN NAME, parameter descriptions, and ICON as MDL comments in DESCRIBE JAVA ACTION output.

…for SSH

…inline preview

…d/mxcli/ Fix all critical and moderate issues from code review: - Fix itoa() for tab numbers >= 10 (#1) - Add TabID to LoadTreeMsg to prevent race condition (#2) - Fix UTF-8 truncation with runewidth (#3) - Change View()/viewZen() to pointer receivers (#4) - Cancel PreviewEngine on tab close and app quit (#5) - Remove ~315 lines dead code in keys.go (#6) - Remove unused NavState, MillerFocusPreview, GoBack, ToggleZen (#7) - Reset traceActive in CloseTrace() (#8) - Remove nolint:govet suppression (#9) - Extract magic numbers as named constants (#10) - Handle openDiagram temp file cleanup and WriteString error (#11) - Remove redundant rebuildZones() call (#12) - Fallback NDSL preview to MDL DESCRIBE for unsupported types - Move bson/ and tui/ packages into cmd/mxcli/ per reviewer suggestion

ako

Code Review: TUI yazi-style Miller columns, image collections, review fixes

Alignment with Image Collection Proposal

The proposal (docs/03-development/proposals/show-describe-image-collections.md) specifies read-only SHOW/DESCRIBE. This PR goes beyond:

Proposal	PR #25	Status
`SHOW IMAGE COLLECTIONS [IN Module]`	Not implemented	Missing
`DESCRIBE IMAGE COLLECTION Module.Name`	Implemented (with temp file extraction)	✅ Extended
—	`CREATE IMAGE COLLECTION`	Beyond scope
—	`DROP IMAGE COLLECTION`	Beyond scope
—	Inline terminal image rendering (Kitty/iTerm2/Sixel/chafa)	Beyond scope
Enhance parser to capture `ImageFormat`	Yes — parser extracts Format, Data, ID	✅

SHOW IMAGE COLLECTIONS (the simpler listing) is missing while the more complex CREATE/DROP were implemented. Consider adding it as a follow-up.

PR #23 Overlap

PR #23 was closed without merging. This PR supersedes it — all 6 commits are rebased in, plus a commit addressing all 12 review issues. No conflicts with main.

Issues to Address in Follow-ups

Moderate:

Image data written to /tmp/mxcli-preview/ with no cleanup (disk leak, mild security concern on shared systems)
detectImageProtocol prioritizes chafa over native Kitty/iTerm2 — should be reversed
imageFormatToExt silently defaults unknown formats to .png
Three plan docs (1,645 lines total) are implementation artifacts, not reference docs

Minor:

renderImageIterm2 reads entire file into memory with no size limit
Generated ANTLR parser accounts for ~12k lines of diff noise

Scope Note

This PR bundles 28 commits across 4 workstreams (TUI rewrite, image collections, package reorg, unrelated fixes). Future PRs should be scoped more narrowly for easier review.

What Looks Good

Image collection implementation (grammar → AST → visitor → executor → BSON writer) follows established patterns well
TUI image rendering with protocol auto-detection is a nice feature
All PR #23 review issues were addressed
Security fix for association member access (CE0066) is correct

Approving — the code quality is solid. Follow-up items noted above.

🤖 Generated with Claude Code

ako · 2026-03-24T09:41:41Z

This PR has merge conflicts with main (in mdl/grammar/MDLParser.g4 and the generated ANTLR parser files).

Could you rebase onto main? The grammar conflict is straightforward — createDemoUserStatement was added on main and needs to coexist with your createImageCollectionStatement in the createStatement rule. The generated parser files just need a make grammar regeneration after resolving.

I tested the rebase locally — build and tests pass cleanly after resolution.

ako · 2026-03-24T09:45:35Z

Merged manually via rebased branch push to main. All 29 commits are on main now.

engalar added 29 commits March 24, 2026 16:13

feat(tui): add debug trace logging (MXCLI_TUI_DEBUG=1)

c508016

Writes to ~/.mxcli/tui-debug.log when MXCLI_TUI_DEBUG=1. Traces: key/mouse events, resize, navigation, preview requests, column width calculations, animation state.

fix(tui): forward animTickMsg to miller, fixing stuck animation

d1dfa42

animTickMsg was not in the forwarding list in app.go Update(), so animation frames never decremented and parent column stayed permanently compressed.

fix(tui): remove column-width animation, use instant transitions

478c0d9

Width-based animation caused all text to reflow simultaneously, creating a dizzying effect. Replaced with clean instant column shifts matching yazi's native behavior.

feat(mpr): add CreateImageCollection BSON writer

88b9f2f

feat(grammar): add COLLECTION token and createImageCollectionStatemen…

b25de3a

…t rule

feat(ast): add CreateImageCollectionStmt and DropImageCollectionStmt

3251612

feat(visitor): add DROP IMAGE COLLECTION handler in ExitDropStatement

64b9843

feat(executor): add CREATE/DROP IMAGE COLLECTION commands

cc101c2

Add executor handlers for image collection statements with module lookup, duplicate detection, and hierarchy invalidation.

feat(tui): add DESCRIBE IMAGE COLLECTION MDL preview in TUI

a80cab7

feat(executor): show image list with temp file paths in DESCRIBE IMAG…

a303527

…E COLLECTION Parse Image.Data, Format, and ID fields from BSON in parser_misc.go. Write image data to /tmp/mxcli-preview/ and display IMAGE lines with file paths in DESCRIBE output.

fix(tui): preserve column cursor position on l/h navigation

a733e94

SetItems() resets cursor to 0; save and restore parentCursor/currentCursor in navEntry so drillIn and goBack keep the selection visible.

fix(tui): add imagecollection icon to typeIconMap

8072b4b

fix(tui): handle nanoflow/javaaction preview gracefully

4b15d07

- nanoflow: return empty (DESCRIBE NANOFLOW not implemented in executor) - javaaction: fix syntax to DESCRIBE JAVA ACTION (two words, matching grammar)

fix(mpr): read image data from 'Image' BSON key instead of 'Data'

ca1ea7e

Writer serializes image bytes under key 'Image' (Images$Image type), but parser was looking for 'Data', so img.Data was always nil and temp files were never written during DESCRIBE IMAGE COLLECTION.

fix(tui): enable javaaction NDSL view

15313c1

Add 'javaaction' to inferBsonType() so Tab toggles to NDSL mode. Add 'JavaActions$JavaAction' type prefix to GetRawUnitByName() so bson dump can resolve javaaction by qualified name.

feat(tui): render ImageCollection images inline with Kitty/iTerm2 pro…

5239b67

…tocol

fix(executor): normalize JavaAction doc \r\n and add metadata comments

4fdb3a5

Normalize \r\n and \r to \n in JavaAction documentation before rendering. Add RETURN NAME, parameter descriptions, and ICON as MDL comments in DESCRIBE JAVA ACTION output.

feat(tui): add Sixel/chafa support and MXCLI_IMAGE_PROTOCOL override …

19de74b

…for SSH

fix(tui): exclude ImageCollection inline images from yank content

4076189

feat(tui): click FROM FILE path to open single image overlay, remove …

8f75145

…inline preview

chore: regenerate ANTLR parser after rebase

68aaad9

engalar force-pushed the pr/tui-improvements-v2 branch from b8bdbaf to 68aaad9 Compare March 24, 2026 08:22

ako approved these changes Mar 24, 2026

View reviewed changes

ako closed this Mar 24, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

TUI: yazi-style Miller columns, image collections, review fixes#25

TUI: yazi-style Miller columns, image collections, review fixes#25
engalar wants to merge 29 commits intomendixlabs:mainfrom
engalar:pr/tui-improvements-v2

engalar commented Mar 24, 2026

Uh oh!

ako left a comment

Uh oh!

ako commented Mar 24, 2026

Uh oh!

ako commented Mar 24, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

engalar commented Mar 24, 2026

Summary

Changes

Test plan

Uh oh!

ako left a comment

Choose a reason for hiding this comment

Code Review: TUI yazi-style Miller columns, image collections, review fixes

Alignment with Image Collection Proposal

PR #23 Overlap

Issues to Address in Follow-ups

Scope Note

What Looks Good

Uh oh!

ako commented Mar 24, 2026

Uh oh!

ako commented Mar 24, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants