fix: address merged microflow review followups#408
fix: address merged microflow review followups#408hjotha wants to merge 2 commits intomendixlabs:mainfrom
Conversation
AI Code ReviewCritical IssuesNone found. Moderate IssuesNone found. Minor Issues
What Looks Good
RecommendationApprove. The PR correctly implements focused bug fixes with appropriate test coverage and documentation updates. The changes are minimal, targeted, and maintain code quality standards. Minor comment clarification suggested but not blocking. Automated review via OpenRouter (Nemotron Super 120B) — workflow source |
1. Manual while-true detection over-triggered when the only continue lived inside a nested loop. The continue scan crossed loop boundaries while the break scan did not, so the outer while could be rebuilt as a manual back-edge. Stop the continue scan at nested loops and add a regression test. 2. Owner-both reverse retrieves feeding add/remove-to-list were still treated as object-only consumers. The list pre-scan ignored AddToListStmt and RemoveFromListStmt target lists, so AssociationRetrieveSource could be suppressed. Track those list consumers and add coverage for the helper. 3. Direct nanoflow describe did not set the return-value render context used by EndEvent formatting. Thread the wrapped nanoflow return type through the formatter so value-returning nanoflows do not emit bare return; for empty EndEvents. Also folds in low-risk review followups: commit-action writer coverage, change-object refresh negative coverage, download-file formatter coverage, reverse-retrieve name validation tightening, and documentation for MXCLI_EXEC_TIMEOUT. Tests: make build Tests: make test Tests: make lint-go Closes mendixlabs#404. Closes mendixlabs#405. Closes mendixlabs#406.
7a08d1b to
3e8d0a6
Compare
AI Code ReviewCritical IssuesNone found. Moderate IssuesNone found. Minor IssuesNone found. What Looks Good
RecommendationApprove. This PR consists of well-targeted bug fixes and test improvements for previously merged microflow/nanoflow functionality. Each change addresses a specific reported issue with appropriate test coverage, and the code quality is maintained throughout. As these are follow-ups to already-merged work and don't introduce new MDL syntax, they appropriately bypass the full-stack consistency requirements for new features while still maintaining the project's standards for bug fixes and test coverage. Automated review via OpenRouter (Nemotron Super 120B) — workflow source |
…ew-followups # Conflicts: # mdl/executor/cmd_microflows_format_action.go
Summary
This PR collects follow-ups from reviews on already-merged microflow roundtrip PRs so the actionable feedback does not get lost.
Fixes:
while truedetection from treatingcontinueinside a nested loop as a continue for the outer loop.add $Item to $Listandremove $Item from $Listtarget lists as list consumers so owner-both reverse retrieves keep the correct source form.describe nanoflowpath so value-returning nanoflows do not emit barereturn;for empty EndEvents.Review follow-up coverage:
ErrorHandlingType.MXCLI_EXEC_TIMEOUTin the quick reference.Closes #404.
Closes #405.
Closes #406.
Tests
make buildmake testmake lint-go