fix: resolve bare change members against inherited attributes#452
Open
hjotha wants to merge 2 commits intomendixlabs:mainfrom
Open
fix: resolve bare change members against inherited attributes#452hjotha wants to merge 2 commits intomendixlabs:mainfrom
hjotha wants to merge 2 commits intomendixlabs:mainfrom
Conversation
Symptom: a change-object member assignment to an inherited attribute could roundtrip into an attribute qualified on the concrete child entity, causing mx check to report that the selected attribute no longer exists. Root cause: resolveMemberChange qualified bare attributes with the variable's concrete entity only and did not walk the entity generalization chain. Fix: when entity metadata is available, resolve bare attribute names against the entity and its ancestors and write the declaring entity qualified name. Tests: added a synthetic inherited-attribute resolver test, ran make build, make test, and a targeted roundtrip with mx check.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #451.
Summary
Validation
make buildmake testmx checkfor an inherited bare attribute case