fix: preserve incoming anchors for inheritance splits#454
Merged
ako merged 1 commit intomendixlabs:mainfrom Apr 30, 2026
Merged
fix: preserve incoming anchors for inheritance splits#454ako merged 1 commit intomendixlabs:mainfrom
ako merged 1 commit intomendixlabs:mainfrom
Conversation
Symptom: combining split-type describe support with default-anchor suppression can relayout inheritance splits with negative X positions and produce invalid branch scoping after exec. Root cause: the describer treated an incoming `to: left` anchor on split-type nodes as suppressible default metadata, but the builder still needs that anchor to preserve the original split geometry. Fix: continue suppressing default incoming anchors for regular exclusive splits, but preserve the incoming anchor for inheritance splits even when the side is `left`. Tests: added a synthetic inheritance-split anchor regression and ran make test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #453.
Summary
to: leftanchors for inheritance splits because they can affect split-type branch geometry and scopingValidation
go test ./mdl/executor -run 'TestEmitSplitAnchor|TestDescribe_FalseBranchFromTop_IfWithoutElseIsDefault'make buildmake test