feat: extend review approval for 'comment' when uncertain#41
Merged
Conversation
|
The changes cleanly implement the new Comment state and correctly propagate the approval-evaluation-prompt-file through the CLI, Action inputs, and internal prompts. Environment variables are used appropriately in action.yml to prevent command injection, adhering to the project's security guidelines. Error handling and testing additions are also solid. Great work maintaining explicit handling of inputs and thorough test coverage. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements #32, introducing a third state to the review verdict:
💬 Comment.Key Changes:
core/prompts/approval_evaluation_prompt.mdwhich defines the criteria for Approve, Reject, and Comment. It prioritizes approval velocity while allowing for a neutral Comment when the reviewer is uncertain.core/prompts/extraction_prompt.mdto correctly map the💬 Commentverdict to a structuredCOMMENTaction withapproved: false.--approval-evaluation-prompt-fileCLI flag and a corresponding GitHub Action input to allow overriding the default guidelines.README.mdandDESIGN.mdto reflect the new configuration options.Tested locally with Bazel; all tests passed.