Skip to content

feat: extend review approval for 'comment' when uncertain#41

Merged
menny merged 1 commit intomainfrom
feature/approval-comment-support
Apr 11, 2026
Merged

feat: extend review approval for 'comment' when uncertain#41
menny merged 1 commit intomainfrom
feature/approval-comment-support

Conversation

@menny
Copy link
Copy Markdown
Owner

@menny menny commented Apr 11, 2026

This PR implements #32, introducing a third state to the review verdict: 💬 Comment.

Key Changes:

  • Default Evaluation Prompt: Added core/prompts/approval_evaluation_prompt.md which defines the criteria for Approve, Reject, and Comment. It prioritizes approval velocity while allowing for a neutral Comment when the reviewer is uncertain.
  • Embedded Guidelines: The evaluation guidelines are now embedded and injected into the main ReAct system prompt.
  • Extraction Logic: Updated core/prompts/extraction_prompt.md to correctly map the 💬 Comment verdict to a structured COMMENT action with approved: false.
  • Customizable Prompt: Added --approval-evaluation-prompt-file CLI flag and a corresponding GitHub Action input to allow overriding the default guidelines.
  • Documentation: Updated README.md and DESIGN.md to reflect the new configuration options.

Tested locally with Bazel; all tests passed.

@github-actions
Copy link
Copy Markdown

The changes cleanly implement the new Comment state and correctly propagate the approval-evaluation-prompt-file through the CLI, Action inputs, and internal prompts. Environment variables are used appropriately in action.yml to prevent command injection, adhering to the project's security guidelines. Error handling and testing additions are also solid. Great work maintaining explicit handling of inputs and thorough test coverage.

Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes cleanly implement the new Comment state, correctly propagate the prompt file, securely use environment variables, and have solid error handling and testing.

@menny menny merged commit d6173c8 into main Apr 11, 2026
2 checks passed
@menny menny deleted the feature/approval-comment-support branch April 11, 2026 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant