refactor: simplify booting logic#279
Merged
augustoccesar merged 1 commit intonextfrom Apr 21, 2026
Merged
Conversation
The abstraction of BackgroudService don't seem to be as important as before now that there are only two of said services. Also they are quire rigid about how they share data, which is a problem for the new architecture that we are going through where more of the infra creation will be on the local server and then shared. This hopefully simplifies it. The services are simple function calls that we can expand on its params and that their params are not tied into the same constraints. Also as part of this, removed the dynamic loading for booting. this also adds to the simplification of it, but is not a blocker if we want to add the loading again instead of a "progress logging".
Druue
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The abstraction of BackgroudService don't seem to be as important as before now that there are only two of said services. Also they are quire rigid about how they share data, which is a problem for the new architecture that we are going through where more of the infra creation will be on the local server and then shared.
This hopefully simplifies it. The services are simple function calls that we can expand on its params and that their params are not tied into the same constraints.
Also as part of this, removed the dynamic loading for booting. This also adds to the simplification of it, but is not a blocker if we want to add the loading again instead of a "progress logging".