Skip to content

refactor: local and remote commands into route#286

Merged
augustoccesar merged 2 commits intonextfrom
ship/refactor-local-and-remote-commands
May 6, 2026
Merged

refactor: local and remote commands into route#286
augustoccesar merged 2 commits intonextfrom
ship/refactor-local-and-remote-commands

Conversation

@augustoccesar
Copy link
Copy Markdown
Member

@augustoccesar augustoccesar commented May 5, 2026

Both local and remote commands implementation were pretty much the same with a small variation to parameters of functions.

This unifies the implementation of them. With that, also changes so that local and remote are a subcommand of a new Linkup command called route.

So:

  • linkup local <name> -> linkup route local <name>
  • linkup remote <name> -> linkup route remote <name>

Also updated the feedback of the command to show which session is being updated and where the target lives for each of the updated services.

> linkup route local service_1

Session: happy-snake
  service_1  ->  http://localhost:9292/

Closes SHIP-2631, SHIP-2630

@augustoccesar augustoccesar self-assigned this May 5, 2026
@augustoccesar augustoccesar force-pushed the ship/refactor-local-and-remote-commands branch from 91f25e4 to 9ce93fd Compare May 5, 2026 14:01
@augustoccesar augustoccesar marked this pull request as ready for review May 5, 2026 14:08
@augustoccesar augustoccesar merged commit 4c4911d into next May 6, 2026
6 checks passed
@augustoccesar augustoccesar deleted the ship/refactor-local-and-remote-commands branch May 6, 2026 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant