[pull] develop from Melon-Tropics:develop#12
Merged
pull[bot] merged 4 commits intomeonBot:developfrom Mar 11, 2020
Merged
Conversation
Honour go-ethereum's Unsubscribe() by allowing calls to it multiple times. To persist Mock field changes within methods, make the methods on the reference instead of the concrete type.
update permissions on secret file to 0700 change log file permissions to 700 change permissions from 700 --> 600 add checkFilePermissions function to client startup make checkFilePermissions return error and refactor using constants make variable names and comments more legible rewrite permissions variable name and switch to &^ include check for directory only change permissions if file exists in logger.go rename readWritePermission --> readWritePerms make cookie permissions 0600
…1337992-overly-permissive-file-permissions2 Check for overly permissive file permissions
…low-multiple-unsubscribe eth: Allow multiple Unsubscribe calls
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]. Want to support this open source service? Please star it : )