Resolve env vars in docker-compose container names#101
Merged
jonathonbyrdziak merged 1 commit intomasterfrom Mar 22, 2026
Merged
Resolve env vars in docker-compose container names#101jonathonbyrdziak merged 1 commit intomasterfrom
jonathonbyrdziak merged 1 commit intomasterfrom
Conversation
getContainerNamesFromDockerComposeFile() now resolves Docker-style
env var patterns like ${CONTAINER_NAME:-ghostagent} to their default
values. Checks .env file in repo dir first, then system environment.
Fixes status/health checks showing literal '${CONTAINER_NAME:-ghostagent}'
and always reporting containers as not running.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getContainerNamesFromDockerComposeFile()now resolves Docker-style env var patterns like${CONTAINER_NAME:-ghostagent}to their actual values.envfile in repo dir first, then system environment, then falls back to the default value after:-${CONTAINER_NAME:-ghostagent}string and always reporting containers as "not running"Test plan
protocol statusshowsghostagentinstead of${CONTAINER_NAME:-ghostagent}.envfile overriding the default.envfile (uses default from:-)🤖 Generated with Claude Code