Refactor watcher, status, start, stop into controller/worker pattern#145
Merged
jonathonbyrdziak merged 1 commit intomasterfrom Mar 23, 2026
Merged
Conversation
- Extract release-watcher.php into ReleaseWatcher class with strategy handler methods instead of a 277-line if/else chain - Split ProtocolStatus execute() into section renderers (renderNodeInfo, renderServices, renderDocker, renderConfiguration, renderSecurity, etc.) - Split provisionInfrastructure() into provisionGitHubCredentials, provisionConfigRepo, provisionSlaveWatchers, provisionCrontab - Split stopContainers() into stopSimpleContainers, stopReleaseContainers, stopTrackedReleaseDirs, sweepOrphanReleases Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
while(true)loop frombin/release-watcher.phpintosrc/Helpers/ReleaseWatcher.phpwith proper controller/worker separation. Strategy handlers (handleReleaseStrategy,handleBlueGreenStrategy,handleBranchStrategy) are isolated workers. Shared logic (fetchAndVerifyTag,initAndCheckoutRelease,buildAndHealthCheck) is extracted into reusable workers.execute()into section renderers (renderNodeInfo,renderServices,renderDocker,renderConfiguration,renderSecurity,renderDisk,renderSummary) with abuildContext()that reads all state once.provisionInfrastructure()into 4 focused workers:provisionGitHubCredentials,provisionConfigRepo,provisionSlaveWatchers,provisionCrontab.stopContainers()into 4 focused workers:stopSimpleContainers,stopReleaseContainers,stopTrackedReleaseDirs,sweepOrphanReleases.Test plan
protocol startfrom a project dir starts containers (strategy=none)protocol stopfrom a project dir stops containersprotocol statusdisplays all dashboard sections correctlyprotocol start --dir=/releases/v1.0.x/starts the correct versionprotocol stop --dir=/releases/v1.0.x/stops just that release🤖 Generated with Claude Code