Fix release.active vs release.current mismatch causing stale status#146
Merged
jonathonbyrdziak merged 1 commit intomasterfrom Mar 23, 2026
Merged
Fix release.active vs release.current mismatch causing stale status#146jonathonbyrdziak merged 1 commit intomasterfrom
jonathonbyrdziak merged 1 commit intomasterfrom
Conversation
Root cause: setActiveVersion writes release.active but resolveActiveDir and ProtocolStatus read release.current — different fields. After deploy, status resolved to the old release dir, breaking crontab checks, watcher PID lookups, and showing the wrong active version. - NodeConfig::resolveActiveDir: check release.active first, fall back to release.current - ProtocolStatus: same priority when reading current release - ProtocolStart: clear Json cache before running status at end of start - ProtocolStatus: only flag active container as issue, not old releases Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
setActiveVersion()writesrelease.activebutresolveActiveDir()andProtocolStatusreadrelease.current— different fields. After deploy, status resolved to the old release directory, breaking crontab checks, watcher PID lookups, and showing the wrong active version.NodeConfig::resolveActiveDir: checkrelease.activefirst, fall back torelease.currentProtocolStatus: same priority fix when reading current release for displayProtocolStart: clearJsoncache before runningprotocol statusat end of startProtocolStatus: only flag the active container as an issue, not old stopped releases (v1.0.0-v1.0.4 showing as issues was noise)Test plan
protocol start, status should show the correct active release version🤖 Generated with Claude Code