Fix global install: direct symlink and command detection#27
Merged
jonathonbyrdziak merged 1 commit intomasterfrom Mar 18, 2026
Merged
Fix global install: direct symlink and command detection#27jonathonbyrdziak merged 1 commit intomasterfrom
jonathonbyrdziak merged 1 commit intomasterfrom
Conversation
- Install script: create /usr/local/bin/protocol symlink directly instead of delegating to self:global (avoids chicken-and-egg PATH issue) - self:global: use `command -v` instead of `which` to avoid false positives from error messages like "which: no protocol in (...)" - Detect user's actual shell for the "source ~/.xxxrc" message Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/usr/local/bin/protocolsymlink directly instead of delegating toself:global— fixes the chicken-and-egg issue whereprotocolisn't in PATH yetself:globalusescommand -vinstead ofwhich—whichon some systems outputs error text likewhich: no protocol in (...)which was treated as a found command~/.bashrcvs~/.zshrc) instead of hardcoding zshTest plan
.bashrcin messageprotocol self:globalwhen no existing command — should succeed without false conflictprotocol self:globalwhen symlink exists — should report conflict correctly🤖 Generated with Claude Code