Skip to content

Replace manifest URL with direct link and ASCII settings table#40

Merged
jonathonbyrdziak merged 1 commit intomasterfrom
fix/github-app-ascii-table
Mar 20, 2026
Merged

Replace manifest URL with direct link and ASCII settings table#40
jonathonbyrdziak merged 1 commit intomasterfrom
fix/github-app-ascii-table

Conversation

@jonathonbyrdziak
Copy link
Copy Markdown
Contributor

Summary

  • GitHub doesn't support manifest flow for private apps — replaces with direct link to app creation page
  • Shows an ASCII table with every field: what to fill in, what to leave blank, what to uncheck
  • Includes a second URL for installing the app after creation
  • Removes unused buildManifest() and manifestUrl() from GitHubApp helper

Test plan

  • Run protocol init → production → private repo → verify ASCII table renders correctly
  • Verify the creation URL points to the correct org
  • Verify the install URL points to the correct org's app settings

🤖 Generated with Claude Code

GitHub doesn't support manifest flow for private apps. Instead,
show a direct link to the app creation page with an ASCII table
of exactly what to fill in and what to leave blank.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@jonathonbyrdziak jonathonbyrdziak merged commit 7602af1 into master Mar 20, 2026
6 of 8 checks passed
@jonathonbyrdziak jonathonbyrdziak deleted the fix/github-app-ascii-table branch March 20, 2026 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant