Stop writing protocol.json to home directory on slave nodes#45
Merged
jonathonbyrdziak merged 1 commit intomasterfrom Mar 20, 2026
Merged
Stop writing protocol.json to home directory on slave nodes#45jonathonbyrdziak merged 1 commit intomasterfrom
jonathonbyrdziak merged 1 commit intomasterfrom
Conversation
Slave node init was writing protocol.json and running git init in
whatever directory the user ran from (e.g. /home/ec2-user/), polluting
the home directory. All slave config is already stored in NodeConfig
at ~/.protocol/.node/nodes/{project}.json — the local protocol.json
was redundant and misplaced.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
flowSlaveNode()that wroteprotocol.jsonand rangit initin the user's working directory (e.g./home/ec2-user/)~/.protocol/.node/nodes/{project}.json— the localprotocol.jsonwas redundant and misplacedgit initthat was creating a git repo in the user's home directoryTest plan
protocol initon a production node — verify noprotocol.jsonappears in the working directory~/.protocol/.node/nodes/{project}.jsoncontains the full config🤖 Generated with Claude Code