Fix config repo resolution on slave nodes#48
Merged
jonathonbyrdziak merged 1 commit intomasterfrom Mar 20, 2026
Merged
Conversation
Four fixes for production/slave node operation: 1. LockableTrait::lock() is private in this Symfony version — alias it as protected so GitSlave/ConfigSlave subclasses can call it 2. Config::repo() now auto-detects slave context via NodeConfig::findByActiveDir() and resolves the config folder name from the node's repo_dir instead of the active release directory 3. ProtocolStart Stage 2 creates a bridge symlink inside the releases directory (e.g., releases/ghostagent-config → ../ghostagent-config) so relative symlinks and docker volume mounts work from both host and container without modifying ConfigLink or docker-compose.yml 4. Config clone in Stage 2 now uses the resolved Config::repo() path instead of computing its own basename (which was wrong on slaves) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NodeConfig::findByActiveDir(), computing the correct config folder name from the node'srepo_dirinstead of the active release directoryProtocolStartStage 2 so relative symlinks from release dirs resolve correctly on both host and inside Docker containersprotectedsoGitSlave/ConfigSlavesubclasses can call itTest plan
protocol starton a slave node — verify no "cannot change to main-config" error~/ghostagent-config/not~/ghostagent-releases/main-config/~/ghostagent-releases/ghostagent-configconfig:linkcreates working symlinks inside the release directorydocker compose upcan mount the config repo via bridge symlinkgit:slaveandconfig:slavedon't error onlock()call🤖 Generated with Claude Code