Verify repos at completion, suppress passthru output#51
Merged
jonathonbyrdziak merged 1 commit intomasterfrom Mar 21, 2026
Merged
Verify repos at completion, suppress passthru output#51jonathonbyrdziak merged 1 commit intomasterfrom
jonathonbyrdziak merged 1 commit intomasterfrom
Conversation
- protocol init now verifies primary repo and config repo are cloned at the completion label, covering both fresh deploy and re-entry paths - Moved config repo clone from pre-completion to completion block so it runs regardless of which path was taken - Changed Shell::passthru to Shell::run in ComposerInstall, GitPull, and ProtocolInit git clone calls so output is captured instead of dumped to screen (respects NullOutput when called from ProtocolStart) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
protocol initnow verifies both primary repo and config repo are cloned at thecompletion:label — covers both fresh deploy and re-entry (user says "no" to changing deployment)Shell::passthru→Shell::runin ComposerInstall, GitPull, and ProtocolInit git clone calls so output is captured instead of dumped to screenNullOutputfromProtocolStart, their output is now properly suppressed (no more composer install dump)Test plan
protocol init→ decline to change deployment → verify repos are checked beforeprotocol startprotocol initfresh → verify both repos clone silently with status messagesprotocol start→ verify no composer output leaks through stagesStageRunnershows clean single-line stages without noise🤖 Generated with Claude Code