Resolve SSH to HTTPS for GitHub App git operations#53
Merged
jonathonbyrdziak merged 1 commit intomasterfrom Mar 21, 2026
Merged
Resolve SSH to HTTPS for GitHub App git operations#53jonathonbyrdziak merged 1 commit intomasterfrom
jonathonbyrdziak merged 1 commit intomasterfrom
Conversation
GitHub App installation tokens only work over HTTPS. Added GitHubApp::resolveUrl() that converts SSH URLs to HTTPS when a GitHub App is configured. The original SSH URL is preserved in NodeConfig — only the working URL for git operations is converted. - GitHubApp::resolveUrl() converts git@github.com:... to https://... - ProtocolInit uses $gitCloneUrl for all git commands, stores original $gitRemote in NodeConfig - ReleaseBuilder::initReleaseDir() resolves URL internally - Release watcher refreshes GitHub App credentials before each deploy Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GitHubApp::resolveUrl()— converts SSH URLs (git@github.com:...) to HTTPS when a GitHub App is configured, so the credential helper can provide the installation tokenReleaseBuilder::initReleaseDir()resolves URL internally + addsGIT_TERMINAL_PROMPT=0Test plan
protocol initwith SSH URL + GitHub App — verify config repo clones successfully via HTTPS🤖 Generated with Claude Code