Fail fast on credential refresh, add git fetch timeouts#56
Merged
jonathonbyrdziak merged 1 commit intomasterfrom Mar 21, 2026
Merged
Fail fast on credential refresh, add git fetch timeouts#56jonathonbyrdziak merged 1 commit intomasterfrom
jonathonbyrdziak merged 1 commit intomasterfrom
Conversation
- ProtocolStart Stage 2 now throws RuntimeException if credential refresh fails instead of silently proceeding with expired tokens - GitHubApp::getAccessToken() logs specific failure reason to protocol log - git fetch commands wrapped with `timeout 30` to prevent indefinite hangs - StageRunner uses `sudo mkdir` for /var/log/protocol/ with NODE_DATA_DIR fallback Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RuntimeExceptionif GitHub App credential refresh fails, instead of silently proceeding with expired tokens that cause git fetch to hangGitHubApp::getAccessToken()logs the specific failure reason (missing PEM, JWT failure, no installation found, etc.) to the protocol loggit fetchcommands wrapped withtimeout 30to prevent indefinite hangssudo mkdir -p /var/log/protocol/with fallback to NODE_DATA_DIRTest plan
protocol startwith valid GitHub App credentials — verify "Credentials refreshed successfully" in logprotocol startwith invalid/expired PEM — verify Stage 2 fails immediately with clear error/var/log/protocol/protocol-start.log🤖 Generated with Claude Code