Store encryption keys per-project in non-production envs#74
Merged
jonathonbyrdziak merged 1 commit intomasterfrom Mar 21, 2026
Merged
Store encryption keys per-project in non-production envs#74jonathonbyrdziak merged 1 commit intomasterfrom
jonathonbyrdziak merged 1 commit intomasterfrom
Conversation
Uses config:env (via IncidentDetector::isDev()) to determine storage location. Production stores globally in protocol's .node/key, all other environments store per-project in .protocol/key. Automatically adds .protocol/ to the project's .gitignore when storing locally. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
config:env— production stores globally inprotocol/.node/key, all other environments (local, dev, staging) store per-project in.protocol/key.protocol/to the project's.gitignore(with duplicate detection)Test plan
protocol secrets:setupin a dev/local environment — verify key is stored at{project}/.protocol/key.protocol/is added to.gitignorewithout duplicates on repeated runsprotocol secrets:setupin a production environment — verify key is stored atprotocol/.node/keysecrets:encryptandsecrets:decryptstill work with the new key paths🤖 Generated with Claude Code