Read blue-green config from node config, not protocol.json#85
Merged
jonathonbyrdziak merged 1 commit intomasterfrom Mar 22, 2026
Merged
Read blue-green config from node config, not protocol.json#85jonathonbyrdziak merged 1 commit intomasterfrom
jonathonbyrdziak merged 1 commit intomasterfrom
Conversation
Blue-green deployment is a node-level concern — the repo's protocol.json shouldn't need to know about it. On slave nodes, isEnabled(), getReleasesDir(), and getGitRemote() now read from node config first, falling back to protocol.json only for local dev / non-slave usage. Also moves release-watcher.log to /var/log/protocol/ when writable. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
enabled,releases_dir,git_remote) is a node-level concern — the repo's protocol.json shouldn't need to know about itisEnabled(),getReleasesDir(), andgetGitRemote()now read from node config first, falling back to protocol.json only for local dev / non-slave usagebluegreen.enabled: truebeing set in node configrelease-watcher.logto/var/log/protocol/when writable (was polluting the repo directory)Root cause
The release-watcher calls
BlueGreen::isEnabled($repo_dir)which only checkedprotocol.jsonin the repo. The node config at~/.protocol/.node/nodes/ghostagent.jsonhadbluegreen.enabled: trueandbluegreen.releases_dir, but these were never read. The watcher fell through to the in-place checkout path, overwriting the branch checkout.Test plan
protocol restartPROTOCOL_ACTIVE_RELEASEto a tagghostagent-releases/v0.1.0/instead of in-place checkoutrelease-watcher.loggoes to/var/log/protocol/🤖 Generated with Claude Code