feat: handle multiple VCALENDAR components in a single ICS file#310
Merged
niccokunzmann merged 3 commits intomergecal:mainfrom Feb 24, 2026
Merged
Conversation
Codecov Report❌ Patch coverage is
🚀 New features to boost your workflow:
|
SashankBhamidi
temporarily deployed
to
release
GitHub Actions
Inactive
abe-101
reviewed
Feb 24, 2026
Member
abe-101
left a comment
abe-101
left a comment
There was a problem hiding this comment.
Change looks good to me; Would like to get @niccokunzmann review for approval
SashankBhamidi
had a problem deploying
to
release
GitHub Actions
Error
niccokunzmann
requested changes
Feb 24, 2026
Collaborator
niccokunzmann
left a comment
niccokunzmann
left a comment
There was a problem hiding this comment.
Hm. It seems we already have a fixture to access the calendars.
Also, keeping a uniform interface is quite nice.
SashankBhamidi
force-pushed
the
feat/multiple-vcalendars-in-one-file
branch
from
699f791 to
0d47176
Compare
Collaborator
Author
|
@niccokunzmann I deferred module-scoped dict fixture, adds complexity without performance benefit for current test scope. |
SashankBhamidi
force-pushed
the
feat/multiple-vcalendars-in-one-file
branch
from
0d47176 to
4536d39
Compare
SashankBhamidi
temporarily deployed
to
release
GitHub Actions
Inactive
niccokunzmann
requested changes
Feb 24, 2026
Collaborator
niccokunzmann
left a comment
niccokunzmann
left a comment
There was a problem hiding this comment.
Generally, it is good to use the existing fixtures. You could even remove two_vcalendars_cals to make the tests slimmer.
I think this should work somehow like this now.
SashankBhamidi
force-pushed
the
feat/multiple-vcalendars-in-one-file
branch
from
4536d39 to
c628558
Compare
niccokunzmann
previously approved these changes
Feb 24, 2026
Collaborator
niccokunzmann
left a comment
niccokunzmann
left a comment
There was a problem hiding this comment.
Cool. Nice that that works!
SashankBhamidi
force-pushed
the
feat/multiple-vcalendars-in-one-file
branch
from
c628558 to
ae2cdeb
Compare
Collaborator
Author
|
Thanks for the reviews - Nicco and Abe! |
SashankBhamidi
temporarily deployed
to
release
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #22
.icsfiles can contain multiple concatenatedVCALENDARblocks. Previously this caused aValueErrorwhen parsing. This addscalendars_from_ical()usingCalendar.from_ical(data, multiple=True)as the single parsing entry point across the CLI and test helpers.