Fix #259: Add pos property with setter and update requirements #297
+30
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the crash reported in #259 where running the Hotelling's Law example (
app.py) on Python 3.12 failed. The crash was caused by two issues:TypeErrorinSpaceDrawerbecause agents lacked aposattribute (due to changes in how Mesa handles agent positions).AttributeErrorcaused by the baseAgentclass attempting to initializeself.pos = None, which conflicted withposbeing defined as a read-only property in the subclasses.Additionally, this PR updates
requirements.txtto include missing dependencies required to run the example.Fix Details
1. Agent Logic (
agents.py)I modified
StoreAgentandConsumerAgentto include a robustposproperty:self.cell.coordinate(the modern Mesa standard) instead of relying on a stored attribute. It includes a check forself.cellto prevent errors before placement.Agent.__init__method attempts to executeself.pos = None. Without this setter, the initialization fails with anAttributeError.2. Dependencies (
requirements.txt)I found that a fresh environment installation failed to run because several imports were missing. I added:
solaramatplotlibnetworkxaltairVerification
I have verified this fix locally on Python 3.12.
solara run app.pyScreenshot of working simulation:

*
*
Related Issue
Fixes #259