Fix for DeprecationWarning from AgentSet.__getitem__

[quaquel]

Sequence behavior on AgentSet is being deprecated. So we call self.agent.to_list() before random.sample in model.step. This also gives a substantial performance boost for this model.

Same fix in warehouse model, which still fails because sequence behavior is used in mesa.experimental's meta_agent stuff. The code in the example is now correct.

[EwoutH]

Looks good, thanks

[EwoutH]

Seems like it's still present? Or was this another warning?

        .. deprecated::
            Sequence behavior (indexing/slicing) is deprecated and will be removed in Mesa 4.0.
            Use :meth:`to_list` instead: ``agentset.to_list()[index]`` or ``agentset.to_list()[start:stop]``.
        """
>       warnings.warn(
            "AgentSet.__getitem__ is deprecated and will be removed in Mesa 4.0. "
            "Use AgentSet.to_list()[index] instead. "
            "See https://mesa.readthedocs.io/latest/migration_guide.html#AgentSet-sequence-behavior",
            PendingDeprecationWarning,
            stacklevel=2,
        )
E       PendingDeprecationWarning: AgentSet.__getitem__ is deprecated and will be removed in Mesa 4.0. Use AgentSet.to_list()[index] instead. See https://mesa.readthedocs.io/latest/migration_guide.html#AgentSet-sequence-behavior

[quaquel]

as indicated in the PR, this is an error in meta agent on mesa itself

[EwoutH]

Right, thanks. Is that problem written up somewhere in the Mesa repo?

Also a PendingDeprecationWarning shouldn't fail the CI. I opened a PR to fix that in #315.

[quaquel]

Right, thanks. Is that problem written up somewhere in the Mesa repo?

will do tomorrow

Also a PendingDeprecationWarning shouldn't fail the CI. I opened a PR to fix that in #315.

this fix was triggered by build/examples on the mesa side. But the CI here uses mesa from pip, so neither works right now.

I guess this CI here should pip install mesa from github not from pip.