Skip to content

Validate llm_model format in ModuleLLM#89

Merged
wang-boyu merged 2 commits intomesa:mainfrom
Harsh-617:fix-modulellm-model-format
Feb 28, 2026
Merged

Validate llm_model format in ModuleLLM#89
wang-boyu merged 2 commits intomesa:mainfrom
Harsh-617:fix-modulellm-model-format

Conversation

@Harsh-617
Copy link
Copy Markdown
Contributor

Fixes #88

Adds early validation for llm_model format and a unit test for this case.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Feb 25, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@wang-boyu wang-boyu added the maintenance Release notes label label Feb 26, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 28, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.35%. Comparing base (379c4d8) to head (0f60b85).
⚠️ Report is 29 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #89      +/-   ##
==========================================
+ Coverage   87.61%   88.35%   +0.73%     
==========================================
  Files          19       19              
  Lines        1405     1425      +20     
==========================================
+ Hits         1231     1259      +28     
+ Misses        174      166       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@wang-boyu
Copy link
Copy Markdown
Member

LGTM. Merging.

@wang-boyu wang-boyu merged commit aeb40c9 into mesa:main Feb 28, 2026
15 checks passed
@Harsh-617 Harsh-617 deleted the fix-modulellm-model-format branch March 2, 2026 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Release notes label

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ModuleLLM gives misleading error when llm_model is missing provider prefix

2 participants