Conversation
NicolasMahe
previously approved these changes
Jun 7, 2019
Member
NicolasMahe
left a comment
NicolasMahe
left a comment
There was a problem hiding this comment.
One small typo. Otherwise, ready to merge 👍
This was referenced Jun 7, 2019
antho1404
force-pushed
the
feature/instance-data
branch
from
390ad8e to
4321b75
Compare
ilgooz
previously approved these changes
Jun 7, 2019
antho1404
commented
Jun 10, 2019
antho1404
commented
Jun 10, 2019
antho1404
commented
Jun 10, 2019
krhubert
previously approved these changes
Jun 10, 2019
Contributor
|
are you sure that writes are atomic without using transactions? it doesn't worth to rm transactions now since db is going to be changed soon, there is no reason to introduce any instability in this period. |
Contributor
|
@antho1404 this is blocking, can you give the last decision about transactions please? |
Member
Author
|
I don't see the issue with the transaction, this is already used in the execution db so I don't see why there is an issue with that |
ilgooz
force-pushed
the
feature/instance-data
branch
from
48bd913 to
55c5adb
Compare
NicolasMahe
approved these changes
Jun 16, 2019
ilgooz
approved these changes
Jun 16, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add instance struct and instance DB