added instancesdk.Get() feature and its gRPC API#1075
Conversation
c7e4ec5 to
eb97c3c
Compare
| package api; | ||
|
|
||
| service Instance { | ||
| rpc Get (GetInstanceRequest) returns (GetInstanceResponse) {} |
There was a problem hiding this comment.
| rpc Get (GetInstanceRequest) returns (GetInstanceResponse) {} | |
| rpc Get (GetInstanceRequest) returns (definition.Instance) {} |
I really recommend to directly returning the Instance definition. That's the directly on the new API. Simpler is better.
Check:
engine/protobuf/api/execution.proto
Lines 9 to 15 in acc3e08
There was a problem hiding this comment.
Also, CreateInstanceResponse should be replaced also by the instance proto definition:
engine/protobuf/api/instance.proto
Lines 15 to 18 in acc3e08
monday task: https://mesg.monday.com/boards/231078139/pulses/231079102/posts/361694557
There was a problem hiding this comment.
I really recommend to directly returning the Instance definition. That's the directly on the new API. Simpler is better.
Check:
engine/protobuf/api/execution.proto
Lines 9 to 15 in acc3e08
I don't agree with this one as discussed before but I can commit the changes as you like, if you prefer that way.
There was a problem hiding this comment.
Let's reach consensus on the forum: https://forum.mesg.com/t/standardisation-of-the-grpc-apis/320
There was a problem hiding this comment.
Also,
CreateInstanceResponseshould be replaced also by the instance proto definition:
engine/protobuf/api/instance.proto
Lines 15 to 18 in acc3e08
monday task: https://mesg.monday.com/boards/231078139/pulses/231079102/posts/361694557
done
depends on #1074