Conversation
antho1404
force-pushed
the
fix/cleanup-sdk
branch
from
dbf0ba4 to
b11a3d5
Compare
NicolasMahe
approved these changes
Jun 24, 2019
Member
NicolasMahe
left a comment
NicolasMahe
left a comment
There was a problem hiding this comment.
I add some comment but they should definitely done in another PR.
| } | ||
| // a task should be executed only if task's service is running. | ||
| status, err := e.m.Status(s) | ||
| instances, err := e.instDB.GetAllByService(s.Hash) |
Member
There was a problem hiding this comment.
this should only access the instanceSDK instead of the DB!
| return &Execution{ | ||
| m: m, | ||
| ps: ps, | ||
| db: db, |
Member
There was a problem hiding this comment.
The service DB should not be injected as a dependency, but the ServiceSDK should
| Instance: instancesdk.New(c, db, instanceDB), | ||
| Execution: executionsdk.New(m, ps, db, execDB), | ||
| Execution: executionsdk.New(ps, db, execDB, instanceDB), | ||
| Event: eventsdk.New(ps, db), |
Member
There was a problem hiding this comment.
Same as previous comments.
Each SDK should have only access to its specific resource database (eg instance SDK accesses only instance DB, and so on) but can also access to "child" sdk based on the way the data are linked together (eg, instance SDK can access to service SDK because instance contains service hash).
antho1404
force-pushed
the
fix/cleanup-sdk
branch
3 times, most recently
from
9284459 to
4abd07a
Compare
antho1404
force-pushed
the
fix/cleanup-sdk
branch
from
4abd07a to
ce914a9
Compare
krhubert
approved these changes
Jun 24, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dependency #1083