Add validation service#1099
Merged
NicolasMahe merged 3 commits intodevfrom Jun 25, 2019
Merged
Conversation
NicolasMahe
reviewed
Jun 25, 2019
Member
I'm not sure to exactly understand, but: if there is no volume defined in the configuration ("main" dependency), then not volume will be mounted when use the |
krhubert
force-pushed
the
fix/service-validation
branch
from
0ea064b to
b7ee499
Compare
NicolasMahe
approved these changes
Jun 25, 2019
Member
NicolasMahe
left a comment
NicolasMahe
left a comment
There was a problem hiding this comment.
The validation seems good but the validation function is not called.
I guess it should be called from ServiceSDK.Create?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've added back service validation but there is one pbm:
If we don't have "main" dependency as before how do we address it in
volumeFrom? hererelated to #1088