Change namespace from string slice to string#1151
Merged
Conversation
krhubert
force-pushed
the
refactor/container-namespace
branch
from
19e643c to
d784f9a
Compare
Use namespace prefix in container instead of accessing config.
krhubert
force-pushed
the
refactor/container-namespace
branch
from
d784f9a to
a175831
Compare
krhubert
force-pushed
the
refactor/container-namespace
branch
from
d829fa1 to
e833e9c
Compare
krhubert
requested review from
NicolasMahe and
antho1404
and removed request for
NicolasMahe
NicolasMahe
approved these changes
Jul 2, 2019
Member
|
let me time to test some edge cases on that one before merge |
antho1404
approved these changes
Jul 2, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #495