Skip to content

Feature/cosmos integration#1205

Closed
krhubert wants to merge 4 commits intodevfrom
feature/cosmos-integration
Closed

Feature/cosmos integration#1205
krhubert wants to merge 4 commits intodevfrom
feature/cosmos-integration

Conversation

@krhubert
Copy link
Copy Markdown
Contributor

@krhubert krhubert commented Aug 5, 2019

This PR starts tendermint node wihtin the engine. It also allows connecting multiple engine instances of tendermint nodes.

DONE ON THIS PR

  • start tendermint node
  • create simple service app that is lunch with tender mint
  • allow to connect multiple tendermint nodes (running in diffrent engine instances)
  • create mesg-tendermint network for multiple engine instances (+ clean up dev script a bit)
  • add config.Tendermint.P2P.Seeds
  • create test-user and validators and put them .tendermint directory

TEST

# start in dev command
$ ./dev
# copy p2p ID  
INFO[0000] P2P Node ID                                   ID=c8876c507d7980ac09031a40a7495b59d942dba8 file=/root/.tendermint/app/config/node_key.json module=p2p

# in seperate terminal
$ MESG_TENDERMINT_P2P_SEEDS=c8876c507d7980ac09031a40a7495b59d942dba8@$(docker inspect -f '{{with index .NetworkSettings.Networks "mesg-tendermint"}}{{.IPAddress}}{{end}}' $(docker ps -f label=com.docker.swarm.service.name=engine -q)):26656  MESG_NAME=engine-1 MESG_SERVER_PORT=50053 MESG_PATH=~/.mesg/0 ./dev

ISSUES

coping a peer id form terminal is not the best way to connect two nodes, any ideas on how can I solve this? I thought put /root/.tendermint/peer_id file and then from the other terminal just cut it.

@krhubert krhubert force-pushed the feature/cosmos-integration branch from 1f64c63 to 6c83842 Compare August 6, 2019 08:58
@krhubert krhubert requested review from NicolasMahe and antho1404 and removed request for antho1404 August 6, 2019 08:59
@krhubert krhubert force-pushed the feature/cosmos-integration branch from 6c83842 to a640bc9 Compare August 6, 2019 09:01
Copy link
Copy Markdown
Member

@antho1404 antho1404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this ready for review? I see there is the database in the source, the service application where we talked about having just the tendermint node for now so maybe there is still some cleanup to do

@krhubert
Copy link
Copy Markdown
Contributor Author

krhubert commented Aug 7, 2019

Is this ready for review? I see there is the database in the source, the service application where we talked about having just the tendermint node for now so maybe there is still some cleanup to do

We need some app to start tendermint node, but I can remove the serviceapp from this PR if needed.

@antho1404
Copy link
Copy Markdown
Member

yes please and also remove the DB state and I think it's best not to have this .tendermint directory but configure all that directly in the source code especially the genesis.

@NicolasMahe NicolasMahe force-pushed the feature/cosmos-integration branch from 9128b74 to ffdbc59 Compare August 9, 2019 09:49
@NicolasMahe NicolasMahe closed this Aug 9, 2019
@NicolasMahe
Copy link
Copy Markdown
Member

closed in favor of #1211

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants