Closed
Conversation
1f64c63 to
6c83842
Compare
6c83842 to
a640bc9
Compare
antho1404
reviewed
Aug 7, 2019
Member
antho1404
left a comment
There was a problem hiding this comment.
Is this ready for review? I see there is the database in the source, the service application where we talked about having just the tendermint node for now so maybe there is still some cleanup to do
Contributor
Author
We need some app to start tendermint node, but I can remove the serviceapp from this PR if needed. |
Member
|
yes please and also remove the DB state and I think it's best not to have this |
9128b74 to
ffdbc59
Compare
Member
|
closed in favor of #1211 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR starts tendermint node wihtin the engine. It also allows connecting multiple engine instances of tendermint nodes.
DONE ON THIS PR
mesg-tendermintnetwork for multiple engine instances (+ clean up dev script a bit).tendermintdirectoryTEST
ISSUES
coping a peer id form terminal is not the best way to connect two nodes, any ideas on how can I solve this? I thought put
/root/.tendermint/peer_idfile and then from the other terminal just cut it.