Possibility to enable/disable network when running the engine#1227
Merged
Possibility to enable/disable network when running the engine#1227
Conversation
antho1404
force-pushed
the
feature/experimental-feature-flag
branch
from
51bd5c3 to
c859315
Compare
antho1404
force-pushed
the
feature/experimental-feature-flag
branch
from
c859315 to
a3ccb6e
Compare
krhubert
reviewed
Aug 14, 2019
NicolasMahe
approved these changes
Aug 15, 2019
Co-Authored-By: krhubert <krhubert@gmail.com>
antho1404
force-pushed
the
feature/experimental-feature-flag
branch
from
311aacb to
3b2c806
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now the engine has a flag
experimental-networkthat isfalseby default.When this flag is enabled the tendermint node is created and started. If not the engine starts without any network.
The
devscript runs the engine with the flag but by default, the network will not be started. If we want to run the network we need to manually run the docker image with the flagexperimental-network