SDK loads the App modules#1249
Merged
NicolasMahe merged 13 commits intodevfrom Aug 26, 2019
Merged
Conversation
# Conflicts: # go.mod
# Conflicts: # core/main.go
Closed
krhubert
approved these changes
Aug 23, 2019
Member
Author
|
@antho1404 please don't remove the link to the dependant PR in the description even if those PRs has been merged. It helps to know that the dependency are now gone and resolve the merge conflicts. |
Member
|
This pull request has been mentioned on MESG Community. There might be relevant details there: https://forum.mesg.com/t/network-implementation-with-cosmossdk/304/15 |
antho1404
approved these changes
Aug 26, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR splits the sdk function into New and NewDeprecated.
NewDeprecatedis used without network and will be deleted in the future.Newis used with network and delegates to the sdk the registration of necessary cosmos module to the cosmos app.