Conversation
krhubert
force-pushed
the
cosmos/tmclient
branch
from
6e61c50 to
33c3377
Compare
| ctx, cancel := context.WithTimeout(context.Background(), 20*time.Second) | ||
| defer cancel() | ||
|
|
||
| out, err := c.Subscribe(ctx, "", "tx.hash='"+txres.Hash.String()+"'") |
There was a problem hiding this comment.
Just to make sure, this subscribe is only to get the result of the txhash but we already have the txres so why do we need to subscribe?
If this subscribe is to wait for the end of the transaction, a timeout of 20 seconds might be too short.
If this subscribe is for some reason get the transaction isn't it a problem that we subscribe after broadcasting? what happens if it's too fast and we didn't subscribe yet? especially that there is a BroadcastTxSync
There was a problem hiding this comment.
This is the first draft of this system. We need to use it to see the best way to implement this ;)
|
This pull request has been mentioned on MESG Community. There might be relevant details there: https://forum.mesg.com/t/network-implementation-with-cosmossdk/304/15 |
4 participants
Create a simple helper that could be used as tendermint client